Update the call to murmurhash in documentation#240
Open
mkmohangb wants to merge 1 commit intoekzhu:masterfrom
Open
Update the call to murmurhash in documentation#240mkmohangb wants to merge 1 commit intoekzhu:masterfrom
mkmohangb wants to merge 1 commit intoekzhu:masterfrom
Conversation
| # can be encoded in 32 bits. | ||
| def _hash_func(d): | ||
| return mmh3.hash32(d) | ||
| return mmh3.hash(d, signed=False) |
There was a problem hiding this comment.
This looks good. I see now that this is the same change I made in #304 - both fix the same problem. I approve this change.
davidlowryduda
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.